Sharad Mishra has uploaded a new change for review.
Change subject: core: Remove deprecated StringHelper in GetDeviceListQuery.
......................................................................
core: Remove deprecated StringHelper in GetDeviceListQuery.
Replaced StringHelper with StringUtils
Change-Id: I917ce720963d95dbc7154dbb692a0bfcccf632f6
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/7238/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
index bc7aa32..9e5dd4a 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
@@ -3,6 +3,7 @@
import java.util.ArrayList;
import java.util.List;
+import org.apache.commons.lang.StringUtils;
import org.ovirt.engine.core.bll.Backend;
import org.ovirt.engine.core.bll.QueriesCommandBase;
import org.ovirt.engine.core.common.businessentities.LUNs;
@@ -13,7 +14,6 @@
import org.ovirt.engine.core.common.queries.GetDeviceListQueryParameters;
import
org.ovirt.engine.core.common.vdscommands.GetDeviceListVDSCommandParameters;
import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
-import org.ovirt.engine.core.compat.StringHelper;
public class GetDeviceListQuery<P extends GetDeviceListQueryParameters>
extends QueriesCommandBase<P> {
@@ -45,7 +45,7 @@
for (LUNs lun : luns) {
// Filtering code should be deprecated once DC level 3.0 is no
longer supported
if (filteringLUNsEnabled) {
- if (!StringHelper.isNullOrEmpty(lun.getvolume_group_id())) {
+ if (!StringUtils.isEmpty(lun.getvolume_group_id())) {
log.debugFormat("LUN with GUID {0} already has VG ID {1},
so not returning it.",
lun.getLUN_id(), lun.getvolume_group_id());
} else if (lunsFromDbById.containsKey(lun.getLUN_id())) {
--
To view, visit http://gerrit.ovirt.org/7238
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I917ce720963d95dbc7154dbb692a0bfcccf632f6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
