Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 29: (1 comment) ok, thanks. I do not fully understand the code, please make sure that: 1. get certificate chain / present / approval happens only for https. 2. if user selects not to accept certificate - certificate is not added to store and also the connection test is not performed. 3. if the certificate is missing in store you get an error in ui as well, you can do this by stopping using debugger after storing certificate and removing it from store, or comment out the store modification. 4. using provider is not possible if certificate is invalid, you can remove certificate from store and try to interact with provider. 5. a sequence of get chain / approval -> test and failure will not reuse previous certificate member in next test attempt, the fact that we store it as member exposes us to this risk. thanks! http://gerrit.ovirt.org/#/c/35485/29/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 830 Line 831 Line 832 Line 833 Line 834 Import provider certificate -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
