Alon Bar-Lev has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 27: (2 comments) http://gerrit.ovirt.org/#/c/35485/27/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 335: if (certs.size() > 0) { Line 336: ConfirmationModel confirmationModel = Line 337: getImportCertificateConfirmationModel(certs.get(0)); Line 338: sourceListModel.setConfirmWindow(confirmationModel); Line 339: importProviderCertificate(); we call this function here and... Line 340: ok = true; Line 341: } Line 342: } Line 343: if (!ok) { Line 413: return confirmationModel; Line 414: } Line 415: Line 416: private void importCertificate() { Line 417: importProviderCertificate(); we call this function also here. any reason we do this in two locations? I like the 1st one as it will enable us to remove the certificate variable from the class. Line 418: sourceListModel.setConfirmWindow(null); Line 419: } Line 420: Line 421: private void cancelImport() { -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
