Yair Zaslavsky has posted comments on this change. Change subject: engine: Import single certificate ......................................................................
Patch Set 28: (7 comments) http://gerrit.ovirt.org/#/c/35485/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java: Line 45: } catch (Exception e) { Line 46: log.error("Error in encoding certificate. Error is {} " + e.getMessage()); Line 47: if (log.isDebugEnabled()) { Line 48: log.debug("", e); Line 49: } > conditional not needed ^^^ just: Done Line 50: } Line 51: } Line 52: Line 53: private CertificateInfo createCertificateInfo(X509Certificate cert) throws GeneralSecurityException { http://gerrit.ovirt.org/#/c/35485/28/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java: Line 361 Line 362 Line 363 Line 364 Line 365 > importProviderCertificatesTitle -> importProviderCertificateTitle Done Line 362 Line 363 Line 364 Line 365 Line 366 > import_provider_certificates -> import_provider_certificate Done Line 370: } Line 371: }, null, false); Line 372: } Line 373: Line 374: private ImportProviderCertificateParameters importCertificatesParams() { > importCertificatesParams -> importCertificateParams Done Line 375: return new ImportProviderCertificateParameters(provider, certificate); Line 376: } Line 377: Line 378: private ConfirmationModel getImportCertificateConfirmationModel(CertificateInfo certInfo) { Line 402: } Line 403: Line 404: private void importCertificate() { Line 405: Frontend.getInstance().runAction(VdcActionType.ImportProviderCertificate, Line 406: importCertificatesParams(), > importCertificatesParams -> importCertificateParams Done Line 407: new IFrontendActionAsyncCallback() { Line 408: Line 409: @Override Line 410: public void executed(FrontendActionAsyncResult result) { http://gerrit.ovirt.org/#/c/35485/28/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 825: @DefaultStringValue("Export Domain is not attached to any Data Center. Data can be retrieved only when the Domain is attached to a Data Center and is active") Line 826: String ExportDomainIsNotAttachedToAnyDcMsg(); Line 827: Line 828: @DefaultStringValue("The provider has the following certificates:\n") Line 829: String theProviderHasTheFollowingCertificates(); > not used ^ Done Line 830: Line 831: @DefaultStringValue("Import provider certificates") Line 832: String importProviderCertificatesTitle(); Line 833: Line 828: @DefaultStringValue("The provider has the following certificates:\n") Line 829: String theProviderHasTheFollowingCertificates(); Line 830: Line 831: @DefaultStringValue("Import provider certificates") Line 832: String importProviderCertificatesTitle(); > importProviderCertificatesTitle -> importProviderCertificateTitle Done Line 833: Line 834: @DefaultStringValue("There are no networks available. Please add additional networks.") Line 835: String thereAreNoNetworksAvailablePleaseAddAdditionalNetworksMsg(); Line 836: -- To view, visit http://gerrit.ovirt.org/35485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9adb21ded6e6d9fb09fc68331872c1cd88f88a9 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
