Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshots ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/35082/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 178: GlusterVolumeSnapshotModel model = (GlusterVolumeSnapshotModel) getWindow(); Line 179: Line 180: model.stopProgress(); Line 181: Line 182: if (returnValue != null && returnValue.getSucceeded()) { > Will do that. Actually there is no specific need for handling else case here. Almost all the cases I dont see specific else case handling in ListModels. What you say ? Line 183: setWindow(null); Line 184: } Line 185: } -- To view, visit http://gerrit.ovirt.org/35082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
