Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshots ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/35082/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 176: Line 177: public void postOnCreateSnapshot(VdcReturnValueBase returnValue, GlusterVolumeSnapshotEntity snapshot) { Line 178: GlusterVolumeSnapshotModel model = (GlusterVolumeSnapshotModel) getWindow(); Line 179: Line 180: model.stopProgress(); > Where is the progress started? Its not required I feel. Will remove this. Line 181: Line 182: if (returnValue != null && returnValue.getSucceeded()) { Line 183: setWindow(null); Line 184: } Line 178: GlusterVolumeSnapshotModel model = (GlusterVolumeSnapshotModel) getWindow(); Line 179: Line 180: model.stopProgress(); Line 181: Line 182: if (returnValue != null && returnValue.getSucceeded()) { > Please handle the failure case Will do that. Line 183: setWindow(null); Line 184: } Line 185: } http://gerrit.ovirt.org/#/c/35082/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.ui.xml: Line 24: color: #FF0000; Line 25: left: 10px; Line 26: padding-left: 5px; Line 27: } Line 28: > Please remove this done Line 29: .checkBoxEditorWidget{ Line 30: width: 450px; Line 31: } Line 32: </ui:style> -- To view, visit http://gerrit.ovirt.org/35082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
