Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshots ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/35082/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java: Line 118: driver.edit(object); Line 119: Line 120: forceWarningLabel.setVisible(object.getForceCreate().getEntity()); Line 121: Line 122: object.getForceCreate().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { > Will change it accordingly. Thanks for the suggestion. I forgot to mention that if you need Presenter to notify View, you can simply add some method in ViewDef interface and call it from within your Presenter (for example, Presenter adds model listener and it calls getView().doSomething() to instruct View to do something upon that event). If you have any questions about this, be sure to let me know and I'll assist. Line 123: @Override Line 124: public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { Line 125: forceWarningLabel.setVisible(object.getForceCreate().getEntity()); Line 126: } -- To view, visit http://gerrit.ovirt.org/35082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I823580ecb127e48e075c437668bfb19ff8ec4467 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
