Omer Frenkel has posted comments on this change. Change subject: core: don't throw an exception, when moving unresponsive VDS to maintenance ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35269/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java: Line 16: protected void executeVdsBrokerCommand() { Line 17: if (getVds().getHighlyAvailableIsConfigured()) { Line 18: try { Line 19: status = getBroker().setHaMaintenanceMode(getParameters().getMode().name(), getParameters().isEnabled()); Line 20: proceedProxyReturnValue(); personally i prefer to override proceedProxyReturnValue() instead of creating exception and then catching it like in UpdateVMVDSCommand (without throwing) or CancelMigrateVDSCommand but its up to you Line 21: } Line 22: catch (RuntimeException e) { Line 23: setVdsRuntimeError(e); Line 24: // prevent exception handler from rethrowing an exception -- To view, visit http://gerrit.ovirt.org/35269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b489f73793ea1135a72bf1a9184e0822386d8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
