Roy Golan has posted comments on this change. Change subject: core: don't throw an exception, when moving unresponsive VDS to maintenance ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35269/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java: Line 47: super(parameters, commandContext); Line 48: _isInternal = parameters.getIsInternal(); Line 49: haMaintenanceFailed = false; Line 50: } Line 51: minor, please move this helper method down the class. its no as important as the rest Line 52: private boolean isHostedEngineOnVds() { Line 53: for (VM vm : vms) { Line 54: if (vm.isHostedEngine()) { Line 55: return true; -- To view, visit http://gerrit.ovirt.org/35269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b489f73793ea1135a72bf1a9184e0822386d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
