Omer Frenkel has posted comments on this change. Change subject: core: don't throw an exception, when moving unresponsive VDS to maintenance ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35269/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java: Line 71: SetHaMaintenanceModeVDSCommandParameters params Line 72: = new SetHaMaintenanceModeVDSCommandParameters(getVds(), HaMaintenanceMode.LOCAL, true); Line 73: if (!runVdsCommand(VDSCommandType.SetHaMaintenanceMode, params).getSucceeded()) { Line 74: // HA maintenance failure is fatal only if the Hosted Engine vm is running on this host Line 75: setSucceeded(isHostedEngineOnVds()); > at a glance this looks good. yes it would be better to make SetHaMaintenanceMode not throw exceptions and return a result we can act upon Line 76: haMaintenanceFailed = true; Line 77: } Line 78: } Line 79: catch (VdcBLLException e){ -- To view, visit http://gerrit.ovirt.org/35269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9b489f73793ea1135a72bf1a9184e0822386d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
