Juan Hernandez has posted comments on this change.

Change subject: packaging: redirect to TLS/SSL using application server
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File backend/manager/modules/root/src/main/webapp/index.html
Line 46:                                <span class="fakeH2">Portals</span>
Line 47:                        </h2>
Line 48:                                <div><a href="UserPortal">User 
Portal</a></div>
Line 49:                                <div><a href="webadmin">Administrator 
Portal</a></div>
Line 50:                                <div><a 
href="OvirtEngineWeb/RedirectServlet?Page=Reports">Reports Portal</a></div>
Yes, sorry.

This index.html page is used as the welcome page and also as the error page 
displayed when a 404 error response is generated, look at 
root.war/WEB-INF/web.xml, you will see this:

  <!-- Go to the index when a page is not found (preserving the
       404 status code): -->
  <error-page>
    <error-code>404</error-code>
    <location>/index.html</location>
  </error-page>

With this configuration the application server *forwards* (as opposed to 
redirect) the request to that page. Forwarding means that the URL will not 
change, for example, if the user requests http://whatever/junk/junk.html the 
result will be that index.html is rendered in the browser, but the URL is still 
http://whatever/junk/junk.html, so if the href is "UserPortal" when that is 
clicked the request will be http://whtever/junk/UserPortal";.

The objective of making the application relative to its own root or introducing 
an /ovirt prefix is a good thing that I support, but that should the subject of 
different changes.
Line 51:                        </div>
Line 52:        </div>
Line 53: </body>


--
To view, visit http://gerrit.ovirt.org/6827
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0d05ce7224548123c9f5f2a1ce09bf090625085
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to