Juan Hernandez has posted comments on this change. Change subject: packaging: redirect to TLS/SSL using application server ......................................................................
Patch Set 3: (1 inline comment) I don't understand why to use a JBoss specific thing (replacement of system properties in web.xml) when you already have a perfectly generic one (replacing during packaging) in the same change. Can you separate this (using system properties) to a different change? Then we can discuss it and maybe apply when 7.1.2 is out and tested. .................................................... File backend/manager/modules/root/src/main/webapp/index.html Line 46: <span class="fakeH2">Portals</span> Line 47: </h2> Line 48: <div><a href="UserPortal">User Portal</a></div> Line 49: <div><a href="webadmin">Administrator Portal</a></div> Line 50: <div><a href="OvirtEngineWeb/RedirectServlet?Page=Reports">Reports Portal</a></div> These three hrefs need to be absolute, prefixed with /, otherwise they will not work when the page is used as error page. Line 51: </div> Line 52: </div> Line 53: </body> -- To view, visit http://gerrit.ovirt.org/6827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d05ce7224548123c9f5f2a1ce09bf090625085 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
