Sahina Bose has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/34552/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 62: // get all clusters Line 63: List<VDSGroup> clusters = getClusterDao().getAll(); Line 64: // for every cluster that supports geo-rep monitoring Line 65: for (VDSGroup cluster : clusters) { Line 66: refreshGeoRepSessionStatusInCluster(cluster); > supportsGlusterGeoRepFeature check needs to be done here as well Done, though session list would be empty for non-supported clusters. Line 67: } Line 68: } Line 69: Line 70: private void refreshGeoRepSessionStatusInCluster(final VDSGroup cluster) { Line 71: List<GlusterGeoRepSession> geoRepSessions = getGeoRepDao().getGeoRepSessionsInCluster(cluster.getId()); Line 72: refreshGeoRepSessionStatus(cluster, geoRepSessions); Line 73: } Line 74: Line 75: public void refreshGeoRepDataForVolume(final GlusterVolumeEntity volume) { > Can you add a comment above to explain this will be called from BLL command Done Line 76: if (volume == null) { Line 77: throw new VdcBLLException(VdcBllErrors.GlusterVolumeGeoRepSyncFailed, "No volume information"); Line 78: } Line 79: VDSGroup cluster = getClusterDao().get(volume.getClusterId()); http://gerrit.ovirt.org/#/c/34552/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusForXmlRpc.java: Line 33: private static final String CRAWL_STATUS = "crawlStatus"; Line 34: Line 35: private final List<GlusterGeoRepSession> geoRepSessions = new ArrayList<GlusterGeoRepSession>(); Line 36: Line 37: protected GlusterGeoRepSessionDetails getSessionDetails(Map<String, Object> innerMap, GlusterGeoRepSession session) { > session is not being used? Nope, remnant from refactoring. Changing method signature Line 38: GlusterGeoRepSessionDetails details = new GlusterGeoRepSessionDetails(); Line 39: Guid masterNodeGlusterId; Line 40: if (innerMap.containsKey(MASTER_NODE_UUID)) { Line 41: masterNodeGlusterId = new Guid(innerMap.get(MASTER_NODE_UUID).toString()); -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
