Yair Zaslavsky has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/34552/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 51: // get all clusters Line 52: List<VDSGroup> clusters = getClusterDao().getAll(); Line 53: // for every cluster that supports geo-rep monitoring Line 54: for (VDSGroup cluster : clusters) { Line 55: discoverGeoRepDataInCluster(cluster, null); Please consider having a method overloading for the case there is no volume name. Line 56: } Line 57: Line 58: } Line 59: Line 182: Line 183: private void updateSlaveNodeAndVolumeId(GlusterGeoRepSession session) { Line 184: // populate ids from the ones that exist in engine Line 185: List<VDS> slaveHosts = getVdsDao().getAllForHostname(session.getSlaveHostName()); Line 186: if (slaveHosts != null && !slaveHosts.isEmpty()) { consider : org.apache.commons.collections.CollectionUtils.isNotEmpty Line 187: session.setSlaveNodeUuid(slaveHosts.get(0).getId()); Line 188: GlusterVolumeEntity slaveVol = Line 189: getVolumeDao().getByName(slaveHosts.get(0).getVdsGroupId(), Line 190: session.getSlaveVolumeName()); http://gerrit.ovirt.org/#/c/34552/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1386: GlusterRefreshRateGeoRepDiscovery, Line 1387: Line 1388: @TypeConverterAttribute(Integer.class) Line 1389: @DefaultValueAttribute("300") Line 1390: GlusterRefreshRateGeoRepStatus, Would be nice to know if in seconds, minutes, etc.. Line 1391: Line 1392: @TypeConverterAttribute(String.class) Line 1393: @DefaultValueAttribute("AttestationService/resources/PollHosts") Line 1394: PollUri, -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
