Piotr Kliczewski has posted comments on this change. Change subject: engine: Monitoring of geo-rep status and statistics ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/34552/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterGeoRepSyncJob.java: Line 93: geoRepSessions consider: org.apache.commons.collections.CollectionUtils.isEmpty() http://gerrit.ovirt.org/#/c/34552/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoDbFacadeImpl.java: Line 202: createIdParameterMapper(geoRepSession.getId()) Line 203: .addValue("status", EnumUtils.nameOrNull(geoRepSession.getStatus()))); Line 204: } Line 205: Line 206: Extra empty line not needed. Line 207: @Override Line 208: public void updateDetails(GlusterGeoRepSessionDetails geoRepSessionDetails) { Line 209: getCallsHandler().executeModification("UpdateGlusterGeoRepSessionDetail", Line 210: createFullParametersMapper(geoRepSessionDetails)); -- To view, visit http://gerrit.ovirt.org/34552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e857ab2ce993cded966fb60b361f6962b9a665 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
