Simone Tiraboschi has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/34940/7/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 280: # verifying the image size before creating them Line 281: # TODO get this values from VDSM APIs instead of hardcoding it Line 282: # TODO now the overhead is > 4GBiB cause we are creating a storage domain Line 283: # maybe we can do better Line 284: BLOCKDEVICE_OVERHEAD_GIB = 5 > Better call it STORAGE_DOMAIN_OVERHEAD_GIB. Done Line 285: METADATA_CHUNK_SIZE = 4096 Line 286: MAX_HOST_ID = 250 Line 287: HA_NOTIF_SMTP_SERVER = 'smtp-server' Line 288: HA_NOTIF_SMTP_PORT = 'smtp-port' -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
