Nir Soffer has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/34940/7//COMMIT_MSG Commit Message: Line 10: disk image so we need to check if we have enough Line 11: free space before starting. Line 12: We need to validate the image size before creating the VG Line 13: so we cannot simply check the VG free space but we need Line 14: a rought estimate of its overhead This will either waste space because the estimate is too careful, or fail when the underlying code will change the behavior. Note that vdsm does not promise the available space on a storage domain, expect the way to check it after you created a domain. Specifying an image size makes sense only after a storage domain is created. If you cannot customize the installation when you have enough info, do not suggest this customization and use the entire device. Line 15: Line 16: Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Line 17: Bug-Url: https://bugzilla.redhat.com/1142710 http://gerrit.ovirt.org/#/c/34940/7/src/ovirt_hosted_engine_setup/constants.py File src/ovirt_hosted_engine_setup/constants.py: Line 277: HOSTED_ENGINE_VM_NAME = 'HostedEngine' Line 278: # On block devices the VM image should be preallocated into the VG Line 279: # The VG by itself introduces some overhead that we need to take care of Line 280: # verifying the image size before creating them Line 281: # TODO get this values from VDSM APIs instead of hardcoding it There are no such api, but it can be easy to add it. Line 282: # TODO now the overhead is > 4GBiB cause we are creating a storage domain Line 283: # maybe we can do better Line 284: BLOCKDEVICE_OVERHEAD_GIB = 5 Line 285: METADATA_CHUNK_SIZE = 4096 Line 280: # verifying the image size before creating them Line 281: # TODO get this values from VDSM APIs instead of hardcoding it Line 282: # TODO now the overhead is > 4GBiB cause we are creating a storage domain Line 283: # maybe we can do better Line 284: BLOCKDEVICE_OVERHEAD_GIB = 5 Better call it STORAGE_DOMAIN_OVERHEAD_GIB. About the size, it should be: - 348MiB used for metadata ((2 * 128MiB) + allignment to 128 extent size.) - Size of existing lvs, you can check this on existing storage domain (inbox, outbox, ids, leases, metadata, master) - Add some slack so it will not break easily if we change the layout. Line 285: METADATA_CHUNK_SIZE = 4096 Line 286: MAX_HOST_ID = 250 Line 287: HA_NOTIF_SMTP_SERVER = 'smtp-server' Line 288: HA_NOTIF_SMTP_PORT = 'smtp-port' -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
