Simone Tiraboschi has posted comments on this change. Change subject: iscsi: checking image size against VG free space ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/34940/7//COMMIT_MSG Commit Message: Line 10: disk image so we need to check if we have enough Line 11: free space before starting. Line 12: We need to validate the image size before creating the VG Line 13: so we cannot simply check the VG free space but we need Line 14: a rought estimate of its overhead > This will either waste space because the estimate is too careful, or fail w I evaluated also the hypothesis of avoiding to offer to the user the possibility to customize the image size directly using all the VG available space for that. But the user can than also create some snapshot of that image so it does make sense to let him choose an image size < VG free space. What about exposing that value from VDSM APIs? Line 15: Line 16: Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Line 17: Bug-Url: https://bugzilla.redhat.com/1142710 -- To view, visit http://gerrit.ovirt.org/34940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17f861a053f6ac38983967ffb07ecca9ff9b8de1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
