Ayal Baron has posted comments on this change.
Change subject: core: validate storage format by data center version
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
Line 146: }
Line 147: return returnValue && CanAddDomain();
Line 148: }
Line 149:
Line 150: private boolean isSupportedStorageFormat() {
not sure there is justification for having this method (as opposed to having a
boolean named isSupportedStorageFormat above.
Line 151: return isStorageFormatSupportedByStoragePool() &&
isStorageFormatSupportedByStorageTypeAndFunction();
Line 152: }
Line 153:
Line 154: private boolean isStorageFormatSupportedByStoragePool() {
Line 170:
Line 171: return true;
Line 172: }
Line 173:
Line 174: private boolean
isStorageFormatSupportedByStorageTypeAndFunction() {
Personally I dislike methods with 'and' in the name.
The general functionality here is that we're checking compatibility between
format and the domain we're creating. so it's
isStorageFormatCompatibleWithDomain or something.
Line 175: StorageFormatType storageFormat =
getStorageDomain().getStorageFormat();
Line 176: StorageType storageType =
getStorageDomain().getstorage_type();
Line 177: StorageDomainType storageDomainFunction =
getStorageDomain().getstorage_domain_type();
Line 178:
--
To view, visit http://gerrit.ovirt.org/6990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
