Tomas Jelinek has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/33770/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java: Line 84: return new TimerImpl(); Line 85: } else if (type == ISpicePlugin.class) { Line 86: return spicePluginProvider.get(); Line 87: } else if (type == ISpiceNative.class) { Line 88: return attachRestApiSessionIdHandler(spiceNativeProvider.get()); the order of events here is not correct because here the RestApiSessionAcquiredEvent has already been fired so the specific impl will not get it. The UiCommonDefaultTypeResolver itself has to listen to the event and just set it to the impls. Line 89: } else if (type == ISpiceHtml5.class) { Line 90: return spiceHtml5Provider.get(); Line 91: } else if (type == IRdpPlugin.class) { Line 92: return rdpPluginProvider.get(); -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
