Martin Betak has posted comments on this change. Change subject: frontend: Pass JSESSIONID in VV file ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/33770/6/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java: Line 30: */ Line 31: public abstract class BaseUiCommonModule extends AbstractGinModule { Line 32: Line 33: protected void bindCommonIntegration() { Line 34: bind(ITypeResolver.class).to(UiCommonDefaultTypeResolver.class).in(Singleton.class); > Please make this to be an eager singleton because the UiCommonDefaultTypeRe Done Line 35: bind(FrontendEventsHandlerImpl.class).in(Singleton.class); Line 36: bind(FrontendFailureEventListener.class).in(Singleton.class); Line 37: bind(ILogger.class).to(LoggerImpl.class).in(Singleton.class); Line 38: http://gerrit.ovirt.org/#/c/33770/6/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java: Line 18: } Line 19: Line 20: protected WebsocketProxyConfig getConfig() { Line 21: if (config != null) { Line 22: new WebsocketProxyConfig( > did you mean Yes, thank you :) Line 23: (String) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.WebSocketProxy), getVncHost()); Line 24: } Line 25: return config; Line 26: } -- To view, visit http://gerrit.ovirt.org/33770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c6d2c91b99240527760b57a6079b5f986aff5b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
