Alon Bar-Lev has posted comments on this change.

Change subject: engine: Method to fetch SSH fingerprint of server
......................................................................


Patch Set 3:

Hi,

Thank you for rebasing, I took the @override statements which are not belong to 
this patch to previous one.

I also don't understand why don't you use the getServerKey() method and extract 
the finger print at mina installer... All you need is connect(), 
getServerKey(), disconnect().

You can even do this within a different client instance if you don't want to 
keep connection open.

Alon

--
To view, visit http://gerrit.ovirt.org/6927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I398fac6cbf641b49c8281937280ae0c351e1d3b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to