Alon Bar-Lev has posted comments on this change. Change subject: engine: Method to fetch SSH fingerprint of server ......................................................................
Patch Set 3: Still this method is not optimal. 1. You already have the server key in serverKey after connection, no need to extract this as you did. 2. There is no reason to disconnect if user approves. Either a callback is appropriate or connect can have two phases, connectOnly and authenticate. -- To view, visit http://gerrit.ovirt.org/6927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I398fac6cbf641b49c8281937280ae0c351e1d3b6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
