anmolbabu has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/33845/8/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java: Line 476: public void testGetClustersByServiceAndCompatibilityVersion() { Line 477: List<VDSGroup> vdsGroups = ((VdsGroupDAODbFacadeImpl)dao).getClustersByServiceAndCompatibilityVersion(true, false, new Version("2.3")); Line 478: assertNotNull(vdsGroups); Line 479: assertEquals(1, vdsGroups.size()); Line 480: assertEquals(new Guid("ae956031-6be2-43d6-bb8f-5191c9253314"), vdsGroups.get(0).getId()); > FixturesTool.GLUSTER_CLUSTER_ID Done Line 481: } http://gerrit.ovirt.org/#/c/33845/8/packaging/dbscripts/vds_groups_sp.sql File packaging/dbscripts/vds_groups_sp.sql: Line 302: AS $procedure$ Line 303: BEGIN Line 304: RETURN QUERY SELECT vds_groups_view.* Line 305: FROM vds_groups_view Line 306: WHERE v_virt_service = virt_service AND v_gluster_service = gluster_service AND v_compatibility_version = compatibility_version; > Change the order to variable at right side of operator Done Line 307: END; $procedure$ Line 308: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
