Sahina Bose has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/33845/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetEligibleVolumesForGeoRepEnablingQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetEligibleVolumesForGeoRepEnablingQuery.java: Line 29: Line 30: getQueryReturnValue().setReturnValue(getOvirtMonitoredVolumesMap(masterVolume)); Line 31: } Line 32: Line 33: private Map<GeoRepEligibility, Map<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>>> getOvirtMonitoredVolumesMap(GlusterVolumeEntity masterVolume) { I do think there has to be a better way to do this. Map<Map<Map<Pair<List... ? I don't think the BLL should be tightly coupled to the UI presentation logic? Wouldn't the simpler way be to pass a master volume, and slave volume and return the List of Non_eligibility_reason? Line 34: Map<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>> nonEligibleList = new HashMap<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>>(); Line 35: Map<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>> eligibleList = new HashMap<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>>(); Line 36: Map<GeoRepEligibility, Map<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>>> geoRepEligibilityMap = new HashMap<GeoRepEligibility, Map<String, Map<GlusterVolumeEntity, Pair<List<String>, List<GEO_REP_NON_ELIGIBILITY_REASON>>>>>(); Line 37: VDSGroup masterVdsGroup = getVdsGroupDao().get(masterVolume.getClusterId()); -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
