Martin Peřina has posted comments on this change. Change subject: core: scanning of configured NICs for health ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/34222/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/enginehealth/NicsHealthCheckManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/enginehealth/NicsHealthCheckManager.java: Line 87: @SuppressWarnings("UnusedDeclaration") Line 88: @OnTimerMethodAnnotation("engineNicHealthCheck") Line 89: public void performEngineNicsHealthCheck() { Line 90: List<NetworkInterface> nicsToCheck = networkInterfacesToCheck(); Line 91: log.debug("Performing engine NICs health check on: " + StringUtils.join(toNicsDisplayNames(nicsToCheck), ", ")); Please don't use string concatenation: log.debug("Performing engine NICs health check on: {}", StringUtils.join(toNicsDisplayNames(nicsToCheck), ", ")); Line 92: Line 93: checkNicsAndUpdateEngineStatus(nicsToCheck); Line 94: Line 95: log.debug("Health check done, engine NICs are {}.", engineNicHealthCache.isAllNicHealthy() ? "healthy" : "unhealthy"); -- To view, visit http://gerrit.ovirt.org/34222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c092ab5d3cf33e1ef83cd0225d2803733fbde89 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
