Martin Peřina has posted comments on this change. Change subject: core: scanning of configured NICs for health ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34222/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/enginehealth/NicsHealthCheckManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/enginehealth/NicsHealthCheckManager.java: Line 99: } catch (SocketException e) { Line 100: String message = String.format("Unable to get network interface '%1$s' status, pronouncing it unhealthy.", Line 101: networkInterface.getDisplayName()); Line 102: log.debug(message, e); Line 103: log.warn(message); > this is new pattern how to log exceptions? I'm aware of (not very common) d We want to reduce amount of stacktraces in engine.log with default log level (INFO), so it's preferred to log only exception message by default and log stacktrace only if log level is DEBUG. Only when message is not enough to identify error, we want to log stacktraces when logging error. And also logging stacktraces by default make engine.log HUGE and nearly unreadable when searching for errors. More info about logging refactoring you can find at: http://lists.ovirt.org/pipermail/devel/2014-October/009028.html http://lists.ovirt.org/pipermail/devel/2014-October/009097.html Line 104: return false; Line 105: } Line 106: } Line 107: -- To view, visit http://gerrit.ovirt.org/34222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c092ab5d3cf33e1ef83cd0225d2803733fbde89 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
