Tal Nisan has posted comments on this change. Change subject: core: Unlock disks upon LSM that failed with CDA in create snapshots part ......................................................................
Patch Set 1: That will be easy to add, but question still remains is what happens if the CDA of the create snapshots command doesn't pass since one of the conditions changed exactly between the LSM CDA and the snapshots CDA, no storage related operation has been done so why should the disks remain in locked status? I'd still keep that fail-safe I've added -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
