Tal Nisan has posted comments on this change. Change subject: core: Unlock disks upon LSM that failed with CDA in create snapshots part ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34612/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java: Line 67: getCreateSnapshotParameters(), Line 68: ExecutionHandler.createInternalJobContext(enclosingCommand.getContext())); Line 69: enclosingCommand.getReturnValue().getVdsmTaskIdList().addAll(vdcReturnValue.getInternalVdsmTaskIdList()); Line 70: // If create snapshots failed on a CDA no operation has been done so it's safe to unlock the disks Line 71: if (!vdcReturnValue.getCanDoAction()) { Perhaps also log an audit log? Maybe with the CDA cause? Line 72: unlockAllDiskSnapshots(); Line 73: enclosingCommand.getReturnValue().setSucceeded(false); Line 74: return; Line 75: } -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
