Tal Nisan has uploaded a new change for review. Change subject: core: Unlock disks upon LSM that failed with CDA in create snapshots part ......................................................................
core: Unlock disks upon LSM that failed with CDA in create snapshots part Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Bug-Url: https://bugzilla.redhat.com/1158049 Signed-off-by: Tal Nisan <tni...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/34612/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java index 8debf85..18d3639 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java @@ -67,6 +67,12 @@ getCreateSnapshotParameters(), ExecutionHandler.createInternalJobContext(enclosingCommand.getContext())); enclosingCommand.getReturnValue().getVdsmTaskIdList().addAll(vdcReturnValue.getInternalVdsmTaskIdList()); + // If create snapshots failed on a CDA no operation has been done so it's safe to unlock the disks + if (!vdcReturnValue.getCanDoAction()) { + unlockAllDiskSnapshots(); + enclosingCommand.getReturnValue().setSucceeded(false); + return; + } } enclosingCommand.getReturnValue().setSucceeded(true); } -- To view, visit http://gerrit.ovirt.org/34612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idba6581587d1908e4428ea2d18878c2f62a0b317 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
