Yair Zaslavsky has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java: Line 70: ); Line 71: Guid vdsmTaskId = taskCreationInfo.getVdsmTaskId(); Line 72: getReturnValue().getVdsmTaskIdList().add(vdsmTaskId); Line 73: if (isRevertedTask) { Line 74: log.info("Reverting task '{}' with ID '{}' on DataCenter '{}'.", > best that every variable string will be marked with quoting to: I am pretty sure I saw some cases where you did not quote. For example - string representations of exceptions. Will you quote them or not? In addition, there is a difference (IMHO) between infra change (and all its derivatives) and other changes. I would prefer in the future to have a patchset that reflects only the infra change. Line 75: taskCreationInfo.getTaskType().name(), Line 76: vdsmTaskId, Line 77: taskCreationInfo.getStoragePoolID()); Line 78: } -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
