Alon Bar-Lev has posted comments on this change.

Change subject: core: Replace oVirt logger with slf4j in bll
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/34359/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java:

Line 103:                 }
Line 104:             } catch (OvfReaderException e) {
Line 105:                 log.error("Failed to parse a given ovf configuration: 
'{}':\n{}",
Line 106:                         ovfEntityData.getOvfData(),
Line 107:                         e.getMessage());
reorder
Line 108:                 log.debug("Exception", e);
Line 109:             }
Line 110:         }
Line 111:     }


http://gerrit.ovirt.org/#/c/34359/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java:

Line 76:                 }
Line 77:             } catch (OvfReaderException e) {
Line 78:                 log.error("Failed to parse a given ovf configuration: 
'{}':\n{}",
Line 79:                         ovfEntityData.getOvfData(),
Line 80:                         e.getMessage());
reorder
Line 81:                 log.debug("Exception", e);
Line 82:             }
Line 83:         }
Line 84:         setVdsGroupId(getParameters().getVdsGroupId());


-- 
To view, visit http://gerrit.ovirt.org/34359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to