Omer Frenkel has posted comments on this change. Change subject: core: Replace oVirt logger with slf4j in bll ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/34359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 347: "Failed to run compensation on startup for Command '{}', Command Id '{}': {}", Line 348: commandSnapshot.getValue(), Line 349: commandSnapshot.getKey(), Line 350: ExceptionUtils.getMessage(e)); Line 351: log.debug("Exception", e); not sure its a good idea to log this in debug... i would leave in error, this happens on engine start, and might change the state in db, so not sure easily reproduced, we should have as much info as we can. Line 352: } Line 353: log.info("Running compensation on startup for Command '{}', Command Id '{}'", Line 354: commandSnapshot.getValue(), commandSnapshot.getKey()); Line 355: } else { http://gerrit.ovirt.org/#/c/34359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java: Line 113: log.error("CommandsFactory : Failed to get type information using reflection for Class '{}', Command Id '{}': {}", Line 114: className, Line 115: commandId, Line 116: e.getMessage()); Line 117: log.debug("Exception", e); not sure about this as well, yair? Line 118: return null; Line 119: } finally { Line 120: if (isAcessible != null) { Line 121: constructor.setAccessible(isAcessible); http://gerrit.ovirt.org/#/c/34359/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java: Line 303: ctx); Line 304: } Line 305: } catch (RuntimeException e) { Line 306: log.error("Failed to initialize Vds on up: {}", e.getMessage()); Line 307: log.debug("Exception", e); please log in error Line 308: } Line 309: } Line 310: }); Line 311: } -- To view, visit http://gerrit.ovirt.org/34359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82070b252197458422792c49b2135fcb9b9b1430 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
