Allon Mureinik has posted comments on this change. Change subject: core: Empty Change CD List when ISO is Inactive ......................................................................
Patch Set 4: Code-Review-1 (2 comments) This makes sense, on it's own right - but where do you use these new methods (in other words - how does this solve the bug)? http://gerrit.ovirt.org/#/c/34031/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java: Line 31: * @param type Line 32: * the storage domain type Line 33: * @return the master storage domain Line 34: */ Line 35: StorageDomain getStorageDomain(Guid storagePoolId, StorageDomainType type); In the other methods in this class you call it poolId. Not sure which is better, but lets keep consistency. Line 36: Line 37: /** Line 38: * Retrieves the storage domain for the specified pool, type and status. Line 39: * http://gerrit.ovirt.org/#/c/34031/4/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java: Line 106: assertEquals(FixturesTool.STORAGE_DOMAIN_NFS_INACTIVE_ISO, result.getId()); Line 107: } Line 108: Line 109: @Test Line 110: public void testGetStorageDomainsWithAndWithoutStatusAreEqual() { Nice! Line 111: StorageDomain resultWithoutStatus = dao.getStorageDomain(FixturesTool.STORAGE_POOL_NFS_INACTIVE_ISO, Line 112: StorageDomainType.ISO); Line 113: StorageDomain resultWithStatus = dao.getStorageDomain(FixturesTool.STORAGE_POOL_NFS_INACTIVE_ISO, Line 114: StorageDomainType.ISO, null); -- To view, visit http://gerrit.ovirt.org/34031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784be2510e2f51be277f7ee06a5bd5573ab23d66 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
