Allon Mureinik has posted comments on this change. Change subject: core: Empty Change CD List when ISO is Inactive ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/34031/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java: Line 39: .addValue("storage_pool_id", poolId) Line 40: .addValue("storage_domain_type", type.getValue()) Line 41: .addValue("status", statusNum)); Line 42: } Line 43: What happened to the @Override here? Line 44: public Guid getIsoStorageDomainIdForPool(Guid poolId) { Line 45: return getStorageDomainId(poolId, StorageDomainType.ISO, StorageDomainStatus.Active); Line 46: } Line 47: Line 41: .addValue("status", statusNum)); Line 42: } Line 43: Line 44: public Guid getIsoStorageDomainIdForPool(Guid poolId) { Line 45: return getStorageDomainId(poolId, StorageDomainType.ISO, StorageDomainStatus.Active); After the comments on the previous patchset I now understand this change. However, I don't think this is the correct place to have this logic. Why not remove this method altogether, and have GetImagesListByStoragePoolIdQuery call "getDbFacade().getStorageDomainDao().getIsoStorageDomainIdForPool(getStoragePoolId(), StorageDomainStatus.ACTIVE)" ? Line 46: } Line 47: Line 48: @Override Line 49: public StorageDomain get(Guid id) { -- To view, visit http://gerrit.ovirt.org/34031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784be2510e2f51be277f7ee06a5bd5573ab23d66 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
