Daniel Erez has posted comments on this change. Change subject: webadmin: import block storage domains - fix refresh ......................................................................
Patch Set 1: (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportSanStorageModel.java Line 104: setItems(null); We usually set items to null when we just need to clear it - no need to create a new object redundantly. On this specific flow, we can set it to a new list, but the nullity check is still needed on 'InitializeItems' for other flows - 'setItems' is set to null from the outer models. Line 144: items.addAll((List<SanTargetModel>) getItems()); I'll insert setItems into to the if clause, but the nullity check is still needed - since setItems is set to null from outer models. -- To view, visit http://gerrit.ovirt.org/6702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
