Ayal Baron has posted comments on this change. Change subject: webadmin: import block storage domains - fix refresh ......................................................................
Patch Set 1: (2 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportSanStorageModel.java Line 104: setItems(null); The point was that items should *never* be null. should be initialized to the below once and only updated wherever needed. Line 144: items.addAll((List<SanTargetModel>) getItems()); But nothing has changed (you add newItems to getItems() you don't replace, so there is no difference also, if getItems() == null you'd do that twice? -- To view, visit http://gerrit.ovirt.org/6702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
