Ayal Baron has posted comments on this change. Change subject: webadmin: import block storage domains - fix refresh ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportSanStorageModel.java Line 104: setItems(null); instead of setting to null here and then setting again in InitializeItems, just set to: new ObservableCollection<SanTargetModel>() and get rid of null check in InitializeItems Line 138: if (getItems() == null) this should never happen. Line 144: items.addAll((List<SanTargetModel>) getItems()); this and setItems at the end should only be performed if (newItems != null), i.e. pushed into following if clause -- To view, visit http://gerrit.ovirt.org/6702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I720d2bb6f2d3a7f7dd228c5337f908b6deab0bb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
