Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/33458/17/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 88: builder = new HttpURLConnectionBuilder().appendRelativePath(hostUrl, relativePath); Line 89: if (isSecured()) { Line 90: builder.setTrustStoreType("JKS") Line 91: .setTrustStorePassword(EngineLocalConfig.getInstance().getPKITrustStorePassword()) Line 92: .setTrustManagerAlgorithm(TrustManagerFactory.getDefaultAlgorithm()) and you should not put defaults as these are defaults. Line 93: .setTrustStore(Paths.get( Line 94: EngineLocalConfig.getInstance().getVarDir().getAbsolutePath(), Line 95: "external_truststore") Line 96: .toString()); Line 92: .setTrustManagerAlgorithm(TrustManagerFactory.getDefaultAlgorithm()) Line 93: .setTrustStore(Paths.get( Line 94: EngineLocalConfig.getInstance().getVarDir().getAbsolutePath(), Line 95: "external_truststore") Line 96: .toString()); > Ok, why should i do that for http? why not? you always have trust store, regardless of protocol. Line 97: } Line 98: result = builder.create(); Line 99: handleCredentials(result); Line 100: } catch (Exception ex) { -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
