Yair Zaslavsky has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/33458/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 63 Line 64 Line 65 Line 66 Line 67 > if url handling is here... why do we have some at the foreman class? Once again, if not - do you want to call the setters that are relevant only to secure connection, also for non secure? Line 69 Line 70 Line 71 Line 72 Line 73 > so we do not need this, move condition into above function... see above. if we are ok with calling .setTrustStorePassword(EngineLocalConfig.getInstance().getPKITrustStorePassword()) .setTrustManagerAlgorithm(TrustManagerFactory.getDefaultAlgorithm()) .setTrustStore(Paths.get( EngineLocalConfig.getInstance().getVarDir().getAbsolutePath(), "external_truststore") .toString()); also in case of non secured connection, then I'm fine with that. Unless i'm missing soething? -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
