Yair Zaslavsky has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 18: (1 comment) http://gerrit.ovirt.org/#/c/33458/18/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 49: List<? extends Certificate> result = null; Line 50: if (url.getProtocol().equalsIgnoreCase(String.valueOf("https"))) { Line 51: HttpURLConnection conn = null; Line 52: try { Line 53: conn = new HttpURLConnectionBuilder(url).setVerifyChain(false).create(); > you can have the new above and in finally only disconnect. The above line throws exception. I think it is ok to have it in try... Line 54: result = Arrays.asList(((HttpsURLConnection) conn).getServerCertificates()); Line 55: } catch (CertificateException | NoSuchAlgorithmException | InvalidKeyException | NoSuchProviderException Line 56: | SignatureException | SSLHandshakeException ex) { Line 57: } catch (IOException | GeneralSecurityException e) { -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
