Allon Mureinik has posted comments on this change. Change subject: [WIP] core: Getting running tasks on VDSM for data center ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) Looks good, +1. Please see inline a minor grammar issue in the commit message and a suggestion for some future refactoring. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java Line 174: ParameterizedRowMapper<Guid> mapper = new IdRowMapper(); This patch is probably not the place for it, but I suggest an additional patch to stop creating new instances of the IdRowMapper, as per http://wiki.ovirt.org/wiki/Backend_Coding_Standards#RowMapper_singletons .................................................... Commit Message Line 9: This added pgsql function accepts as parameter ID of data center and returns s/as/as a/ -- To view, visit http://gerrit.ovirt.org/6674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf8037ba1d12f40b924108fde5c4b9bdbcda8437 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
