Allon Mureinik has posted comments on this change. Change subject: [WIP] core: Getting running tasks on VDSM for data center ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) like the approach, and the implementation looks fine too. A minor styling comment inline, no biggie. .................................................... File backend/manager/dbscripts/async_tasks_sp.sql Line 78: JOIN async_tasks_entities task_ent on sd_map.storage_id = task_ent.entity_id Minor: change ON to upper case next time you rebsae -- To view, visit http://gerrit.ovirt.org/6674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf8037ba1d12f40b924108fde5c4b9bdbcda8437 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
