Allon Mureinik has posted comments on this change. Change subject: [WIP] core: Getting number of running asyn tasks on VDSM for data center ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/dbscripts/storages_sp.sql Line 237: LEFT OUTER JOIN async_tasks_entities task_ent on sd_map.storage_id = task_ent.entity_id where storage_pool_id = v_storage_pool_id Capitalize the where clause, and put it on it's own separate line Line 238: GROUP BY sd_map.storage_pool_id; If you;re only allowing one storage pool id, what is the point of the GROUP BY clause? -- To view, visit http://gerrit.ovirt.org/6674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf8037ba1d12f40b924108fde5c4b9bdbcda8437 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
