Omer Frenkel has posted comments on this change. Change subject: core: Cluster parameters override - scheduler \ actions \ queries ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/32548/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java: Line 41: } Line 42: return null; Line 43: } Line 44: Line 45: public static String GetCpuNameByCpuId(String name, Version ver) { methods should start with lower case latter, i know old methods here do not apply this but its wrong Line 46: final CpuFlagsManager cpuFlagsManager = _managersDictionary.get(ver); Line 47: if (cpuFlagsManager != null) { Line 48: return cpuFlagsManager.GetCpuNameByCpuId(name); Line 49: } Line 260: } Line 261: return result; Line 262: } Line 263: Line 264: public String GetCpuNameByCpuId(String vdsName) { lowerCasePlease ;) Line 265: String result = null; Line 266: ServerCpu sc = null; Line 267: if (vdsName != null) { Line 268: if ((sc = _intelCpuByVdsNameDictionary.get(vdsName)) != null http://gerrit.ovirt.org/#/c/32548/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java: Line 106: } else if (policyUnit.getPolicyUnitType() == PolicyUnitType.WEIGHT) { Line 107: return new VmAffinityWeightPolicyUnit(policyUnit); Line 108: } Line 109: case "Emulated-Machine": Line 110: return new EmulatedMachineFilterPolicyUnit(policyUnit); indent left? Line 111: default: Line 112: break; Line 113: } Line 114: throw new NotImplementedException("policyUnit: " + policyUnit.getName()); http://gerrit.ovirt.org/#/c/32548/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java: Line 83: return customEmulatedMachine; Line 84: } Line 85: Line 86: public void setCustomEmulatedMachine(String customEmulatedMachine) { Line 87: this.customEmulatedMachine = ((customEmulatedMachine == null || customEmulatedMachine.length() == 0) ? null : customEmulatedMachine); please use trim().isEmpty() instead of length check Line 88: } Line 89: Line 90: public String getCustomCpuName() { Line 91: return customCpuName; -- To view, visit http://gerrit.ovirt.org/32548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
