Omer Frenkel has posted comments on this change. Change subject: core: Cluster parameters override - scheduler \ actions \ queries ......................................................................
Patch Set 1: (1 comment) SLA buddies, any comments on the filters? http://gerrit.ovirt.org/#/c/32548/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java: Line 83: return customEmulatedMachine; Line 84: } Line 85: Line 86: public void setCustomEmulatedMachine(String customEmulatedMachine) { Line 87: this.customEmulatedMachine = ((customEmulatedMachine == null || customEmulatedMachine.length() == 0) ? null : customEmulatedMachine); please use trim().isEmpty() instead of length check Line 88: } Line 89: Line 90: public String getCustomCpuName() { Line 91: return customCpuName; -- To view, visit http://gerrit.ovirt.org/32548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
