Eldan Shachar has posted comments on this change. Change subject: core: Cluster parameters override - scheduler \ actions \ queries ......................................................................
Patch Set 1: (6 comments) http://gerrit.ovirt.org/#/c/32548/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java: Line 41: } Line 42: return null; Line 43: } Line 44: Line 45: public static String GetCpuNameByVDSVerbData(String name, Version ver) { > please rename to getCpuNamebyCpuId Done Line 46: final CpuFlagsManager cpuFlagsManager = _managersDictionary.get(ver); Line 47: if (cpuFlagsManager != null) { Line 48: return cpuFlagsManager.GetCpuNameByVDSVerbData(name); Line 49: } Line 260: } Line 261: return result; Line 262: } Line 263: Line 264: public String GetCpuNameByVDSVerbData(String vdsName) { > rename the same Done Line 265: String result = null; Line 266: ServerCpu sc = null; Line 267: if (vdsName != null) { Line 268: if ((sc = _intelCpuByVdsNameDictionary.get(vdsName)) != null http://gerrit.ovirt.org/#/c/32548/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 680: } Line 681: Line 682: // get what cpu flags should be passed to vdsm according to cluster Line 683: // cpu name Line 684: getVm().setVdsGroupCpuFlagsData( > do we still need this parameter? We currently use it only for this function, removed parameter from VM object and replaced the single use with an inline code. Line 685: CpuFlagsManagerHandler.GetVDSVerbDataByCpuName(getVm().getVdsGroupCpuName(), getVm() Line 686: .getVdsGroupCompatibilityVersion())); Line 687: Line 688: VmHandler.updateVmGuestAgentVersion(getVm()); http://gerrit.ovirt.org/#/c/32548/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 56: Line 57: @Override Line 58: protected boolean canDoAction() { Line 59: /* if run-once was used then the dynamic vm fields must be updated before running the scheduler filters (which are called via super.CanDoAction->runVmValidator) */ Line 60: earlyUpdateVmDynamicRunOnce(); > please move to ctor Done Line 61: Line 62: if (!super.canDoAction()) { Line 63: return false; Line 64: } http://gerrit.ovirt.org/#/c/32548/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java: Line 42: log.debugFormat("Host {0} wasn't filtered out as it supports the VM required emulated machine ({1})", Line 43: host.getName(), Line 44: requiredEmulatedMachine); Line 45: } else { Line 46: log.debugFormat("Host {0} was filtered out as it doesn't support the VM required emulated machine ({1})", > worth adding the host values list Done Line 47: host.getName(), Line 48: requiredEmulatedMachine); Line 49: messages.addMessage(host.getId(), String.format("$vmEmulatedMachine %1$s", requiredEmulatedMachine)); Line 50: messages.addMessage(host.getId(), VdcBllMessages.VAR__DETAIL__UNSUPPORTED_EMULATED_MACHINE.toString()); Line 46: log.debugFormat("Host {0} was filtered out as it doesn't support the VM required emulated machine ({1})", Line 47: host.getName(), Line 48: requiredEmulatedMachine); Line 49: messages.addMessage(host.getId(), String.format("$vmEmulatedMachine %1$s", requiredEmulatedMachine)); Line 50: messages.addMessage(host.getId(), VdcBllMessages.VAR__DETAIL__UNSUPPORTED_EMULATED_MACHINE.toString()); > worth adding the host values list Done Line 51: } Line 52: } Line 53: } Line 54: return hostsToRunOn; -- To view, visit http://gerrit.ovirt.org/32548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea8117d8416c74b381aa8475c3fc8b02a344dbfb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
