Maor Lipchuk has posted comments on this change.
Change subject: core:Replace vm id with number of vms in views.
......................................................................
Patch Set 8: (5 inline comments)
....................................................
File backend/manager/dbscripts/create_functions.sql
Line 279: FROM images_storage_domain_view LEFT OUTER JOIN vm_device ON
vm_device.device_id = images_storage_domain_view.disk_id
Done
....................................................
File backend/manager/dbscripts/create_views.sql
Line 22: CREATE OR REPLACE VIEW vm_for_disk_view
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
Line 25: private ArrayList<String> vmNames;
good question.
It is a limitation of GWT, when using business entities we need to explicitly
use the concrete class because of serialization issues.
the rpc create new list on rpc and it can't use List since it is an interface.
Line 37: ArrayList<String> vmNames,
See comment above
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java
Line 25: : new
ArrayList<String>(Arrays.asList(vmNames.split(","))));
Can't use list see previous comment on the patch (serialization issued)
--
To view, visit http://gerrit.ovirt.org/5216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
