Maor Lipchuk has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/dbscripts/create_views.sql Line 21: CREATE OR REPLACE VIEW vm_count_for_device_view There is no reason to fetch other devices then disks .................................................... File backend/manager/dbscripts/storages_sp.sql Line 537: JOIN vm_device ON vm_device.device_id = vm_images_view.disk_id It's already started in a new line here. -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
