Maor Lipchuk has posted comments on this change.

Change subject: core:Replace vm id with number of vms in views.
......................................................................


Patch Set 6: (2 inline comments)

....................................................
File backend/manager/dbscripts/create_views.sql
Line 23: SELECT device_id,entity_type,count(*) as number_of_vms
Added an array in postgres, but kept it in the memory since analyse the query 
is still the same after this change.

....................................................
File backend/manager/dbscripts/storages_sp.sql
Line 525:       CREATE GLOBAL TEMPORARY TABLE tt_TEMPTEMPLATESTABLE AS select 
vm_device.vm_id as vm_guid
done

--
To view, visit http://gerrit.ovirt.org/5216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id306d8322245780ea200c10f9e96254cddf3bc76
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to